Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run "design approved" check when necessary #336

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Only run "design approved" check when necessary #336

merged 2 commits into from
Jul 10, 2024

Conversation

PlasmaPower
Copy link
Collaborator

This is a copy of OffchainLabs/nitro#2468 for the go-ethereum repo

@cla-bot cla-bot bot added the s CLA signed label Jul 10, 2024
joshuacolvin0
joshuacolvin0 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit e45b549 into master Jul 10, 2024
7 checks passed
@joshuacolvin0 joshuacolvin0 deleted the better-design-approved-check branch July 10, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
design-approved s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PlasmaPower @joshuacolvin0